table enhancement #313
Merged
table enhancement #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having a separate table for each config file type has the problem that the the column width are different for each type. Also the comment is written in a separate line This change shows everything in a single table with a tbody for each type. The types are separated by some space and each type has a header with title and column description. Each file is on one line. Styling is moved to a dedicated css file. remove inline style
|
I like this PR, makes the UI looks so much cleaner |
|
I like it as well. Thanks! |
alecharp
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having a separate table for each config file type has the problem that the the column width are different for each type. Also the comment is written in a separate line
This change shows everything in a single table with a tbody for each type. The types are separated by some space and each type has a header with title and column description. Each file is on one line. Styling is moved to a dedicated css file.
remove inline style
Before:
After:
Testing done
Submitter checklist