Toolchains jdk substitution #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I forgot to git add the testcase in the second commit. |
The idea is to provide one or more Jenkins-wide file templates for toolchains.xml. The template contains preconfigured jdk toolchain entries with an id that is equal to Jenkins's JDK tool configuration. In the toolchains.xml template, these entries are adjusted to use the javaHome from Jenkins's JDK tool. If there are multiple JDK installations for the same java version in the template, Maven can reference the desired one by id. If Jenkins's JDK tools cannot be found in the toolchains.xml template, they are not added to the toolchains.xml and a warning is printed per JDK tool. Finally, there is a new option "Remove unavailabe JDK toolchains". This will check the toolchains.xml for JDK toolchains and remove all those where the jdkHome does not exist (on the target node). This is to avoid Maven failing due to inexistant toolchains, e.g. when there are many JDKs defined on the Jenkins, but not all of them available on the build nodes.
cpfeiffer
force-pushed
the
toolchains-jdk-substitution
branch
from
4adbd57
to
20e96a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the desire to ensure that the Maven
toolchains.xmluses the JDK installations configured in Jenkins. E.g. the JDK that is used to start a Maven job shall also be available in thetoolchains.xml.Unfortunately it is not possible to simply add Jenkins's JDK tools automatically to
toolchains.xml, since it is not possible to infer the JDK version from a JDK tool (there's just the name and the jdkHome available).So we took a simple approach of letting the user configure a template for the
toolchains.xmlwith JDKs already preconfigured, except for the jdkHomes. When generating thetoolchains.xml, we simply look up the toolchain in the template (matching a JDK tool name) and set the jdkHome for it.WDYT?