Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the desire to ensure that the Maven
toolchains.xml
uses the JDK installations configured in Jenkins. E.g. the JDK that is used to start a Maven job shall also be available in thetoolchains.xml
.Unfortunately it is not possible to simply add Jenkins's JDK tools automatically to
toolchains.xml
, since it is not possible to infer the JDK version from a JDK tool (there's just the name and the jdkHome available).So we took a simple approach of letting the user configure a template for the
toolchains.xml
with JDKs already preconfigured, except for the jdkHomes. When generating thetoolchains.xml
, we simply look up the toolchain in the template (matching a JDK tool name) and set the jdkHome for it.WDYT?