Skip to content

Commit

Permalink
Stop hiding credentials configuration category (#1752)
Browse files Browse the repository at this point in the history
  • Loading branch information
timja committed Oct 1, 2021
1 parent 7b958de commit 0246dc8
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
public class GlobalConfigurationCategoryConfigurator extends BaseConfigurator<GlobalConfigurationCategory> implements RootElementConfigurator<GlobalConfigurationCategory> {

private static final Logger LOGGER = Logger.getLogger(GlobalConfigurationCategoryConfigurator.class.getName());
private static final String CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION = "com.cloudbees.plugins.credentials.CredentialsProviderManager$Configuration";

private final GlobalConfigurationCategory category;

Expand Down Expand Up @@ -122,14 +121,7 @@ private void describe(Descriptor d, Mapping mapping, ConfigurationContext contex
}

private boolean filterDescriptors(Descriptor d) {
if (d.clazz.getName().equals(CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION)) {
// CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION is located in the wrong category.
// JCasC will also turn the simple name into empty string
// It should be a part of the credentials root configurator node.
return false;
} else {
return d.getCategory() == category && d.getGlobalConfigPage() != null;
}
return d.getCategory() == category && d.getGlobalConfigPage() != null;
}

}

0 comments on commit 0246dc8

Please sign in to comment.