Stop hiding credentials configuration category #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was returning empty string because the symbol guessing logic was stripping everything A symbol was added in jenkinsci/credentials-plugin#144 back in April 2020
This was referenced Oct 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
============================================
- Coverage 80.81% 80.80% -0.02%
+ Complexity 836 835 -1
============================================
Files 71 71
Lines 2466 2464 -2
Branches 346 345 -1
============================================
- Hits 1993 1991 -2
Misses 363 363
Partials 110 110
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was returning empty string because the symbol guessing logic was
stripping everything
A symbol was added in jenkinsci/credentials-plugin#144 back in April 2020
Part of fixing jenkinsci/azure-keyvault-plugin#92 (other part in credentials plugin)