Update ci to include code coverage after #1215 #1241

jetersen · 2019-12-27T06:55:47Z

After #1215 the code coverage was not properly calculated.
Let's have jacoco aggregate the report :)

I'd like to use codecov to report diff coverage.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or in Jenkins JIRA
Link to relevant pull requests, esp. upstream and downstream changes
Did you provide a test-case? That demonstrates feature works or fixes the issue.

report/pom.xml

oleg-nenashev

I am not 100% sure it is justified, but why not? :)

jetersen · 2019-12-27T09:24:35Z

Coverage went from 80% to 26%
https://app.codacy.com/manual/casz/configuration-as-code-plugin/dashboard

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

report/pom.xml

oleg-nenashev

Not blocking it

…ub yet https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/9 This reverts commit 04b70ae.

jetersen · 2020-01-10T22:44:33Z

~~Dropped the aggregating report.~~

GitHub action does not yet have an API, allowing codecov to whitelist github actions coverage reports ie. going tokenless.

So I changed travis to bionic and build with JDK 11 for faster builds.

jetersen · 2020-01-10T22:53:59Z

Hmm test coverage is still not properly calculated.
We need the aggregation

This reverts commit aba9663.

codecov · 2020-01-10T22:57:48Z

Codecov Report

❗ No coverage uploaded for pull request base (master@af878f8). Click here to learn what that means.
The diff coverage is 73.2%.

@@            Coverage Diff            @@
##             master    #1241   +/-   ##
=========================================
  Coverage          ?   78.96%           
  Complexity        ?      780           
=========================================
  Files             ?       65           
  Lines             ?     2301           
  Branches          ?      321           
=========================================
  Hits              ?     1817           
  Misses            ?      383           
  Partials          ?      101

Impacted Files	Coverage Δ	Complexity Δ
...l/configurators/HeteroDescribableConfigurator.java	`85.98% <ø> (ø)`	`47 <0> (?)`
...ain/java/io/jenkins/plugins/casc/Configurator.java	`71.87% <0%> (ø)`	`16 <0> (?)`
...c/main/java/io/jenkins/plugins/casc/Attribute.java	`68.81% <13.33%> (ø)`	`75 <2> (?)`
.../io/jenkins/plugins/casc/ConfigurationContext.java	`83.33% <25%> (ø)`	`16 <0> (?)`
...java/io/jenkins/plugins/casc/SchemaGeneration.java	`93.97% <97.27%> (ø)`	`48 <27> (?)`

jetersen · 2020-01-11T00:03:12Z

okay plugin-pom's enable-jacoco does not behave well with multi module

jetersen · 2020-01-11T03:23:06Z

lots of derping around :D

* Add support to backup and restore automatically * Fix the potential output resource leak * Add configs about deploy into alauda update-center * Set alauda as the main branch * Add sonarqube properties file * Fix the potentital issues * Add a merge strategy extension point for the YAML config (#1) * Add YAML merge strategy * Add a new merge strategy * Remove override merge strategy * Clean the unused code lines * Clean the unused imports * Add test cases for merge strategy * Fix the wrong test cases * Take merge strategy name everytime * Give the default strategy a more readable name * Validate top README with the Integrations tests (jenkinsci#1229) * Fix the compilation error caused by merge strategy * Fix issues which found by spotbugs * Remove unused imports * Move profiles from pom.xml into settings file * Remove empty line * rename the shared-library * Schema Generation for nested yml configurations (jenkinsci#1027) * Trying to diagnose some flaky tests (jenkinsci#1243) * Update ci to include code coverage after jenkinsci#1215 (jenkinsci#1241) Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com> * Checkstyle ignore release.properties (jenkinsci#1245) * [maven-release-plugin] prepare release configuration-as-code-1.35 * [maven-release-plugin] prepare for next development iteration * Bump jackson.version from 2.10.1 to 2.10.2 Bumps `jackson.version` from 2.10.1 to 2.10.2. Updates `jackson-databind` from 2.10.1 to 2.10.2 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-dataformat-yaml` from 2.10.1 to 2.10.2 - [Release notes](https://github.com/FasterXML/jackson-dataformats-text/releases) - [Commits](FasterXML/jackson-dataformats-text@jackson-dataformats-text-2.10.1...jackson-dataformats-text-2.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Correct spelling of hpi.pluginChangelogUrl tag (jenkinsci#1248) * Automatically request code reviews from all JCasC plugin developers (jenkinsci#1249) * [Security] Bump checkstyle from 8.26 to 8.29 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.26 to 8.29. **This update includes a security fix.** - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.26...checkstyle-8.29) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * It has been renamed to `master.componentName` (jenkinsci#1256) Co-authored-by: Tim Jacomb <t.jacomb@kainos.com> * Fix the version specification for Jenkins 2.199 (jenkinsci#1268) * Added example for credentials certificate (jenkinsci#1270) * Use the latest shared-library branch * Update test to match latest plugin version (jenkinsci#1273) * Update the integration test for active-directory (jenkinsci#1274) * Add integration test for pipeline-model-definition (jenkinsci#1276) * Fix the error when no casc user dir (#5) * Add missing of mode in the context * Use the same version of jackson-core * Use the same version of jackson-core * Use 2.8 as the major version * Fix the wrong parent id for the plugin releasing * Move the user config into a backup dir * Run build under java pod Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Sladyn <sladynnunes98@gmail.com> Co-authored-by: Jesse Glick <jglick@cloudbees.com> Co-authored-by: Joseph Petersen <josephp90@gmail.com> Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com> Co-authored-by: Tim Jacomb <t.jacomb@kainos.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com> Co-authored-by: Jhon Mike <jhon.msdev@gmail.com> Co-authored-by: Dawid Gosławski <50369002+dg-nvm@users.noreply.github.com> Co-authored-by: choeffer <33625292+choeffer@users.noreply.github.com> Co-authored-by: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>

aggregate code coverage

41b493b

jetersen added the chore a PR that adds to maintenance - used by Release Drafter label Dec 27, 2019

oleg-nenashev reviewed Dec 27, 2019

View reviewed changes

report/pom.xml Outdated Show resolved Hide resolved

oleg-nenashev reviewed Dec 27, 2019

View reviewed changes

jetersen requested a review from timja January 10, 2020 17:25

wording

497351e

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

jetersen commented Jan 10, 2020

View reviewed changes

report/pom.xml Outdated Show resolved Hide resolved

spacing

af878f8

timja approved these changes Jan 10, 2020

View reviewed changes

oleg-nenashev approved these changes Jan 10, 2020

View reviewed changes

jetersen added 13 commits January 10, 2020 19:29

Merge branch 'master' into fix/aggregateReport

dd01def

remove travis

04b70ae

update github action to report coverage

6d8fee6

use bash shell

ebbb1fa

use package to avoid caching configuration-as-code on github

43e007b

skip maven deploy for report

5f9f613

formatting

dbd5dff

run coverage reporting separately

7e9226e

locate path to report

7845702

-P no space

056f68f

say no to report aggregation

aba9663

Revert "remove travis" as tokenless codecov is not possible with gith…

318aab2

…ub yet https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/9 This reverts commit 04b70ae.

tokenless with travis...

bcc342c

jetersen changed the title ~~aggregate code coverage for JCasC~~ update ci to include code coverage for JCasC Jan 10, 2020

jetersen changed the title ~~update ci to include code coverage for JCasC~~ update ci to include code coverage after #1215 Jan 10, 2020

faster travis build

d4570fb

Revert "say no to report aggregation"

ff907c5

This reverts commit aba9663.

add jacoco aggregate

b27a469

jetersen added 4 commits January 10, 2020 23:58

no thanks to codecov graph

e038a81

fix missing jacoco data execution

827f1e7

avoid calling jacoco:report twice

4101399

shush codacy!

4851ed2

jetersen added 7 commits January 11, 2020 01:16

fix report aggregation

07f896b

fix report aggregation part 2

3190440

fix report aggregation part 3

950f9c8

fix report aggregation part over 9000

f82cf4a

remove report

cafa327

words

4372110

finally

07cc70b

jetersen requested review from timja and oleg-nenashev January 11, 2020 03:41

timja approved these changes Jan 11, 2020

View reviewed changes

timja changed the title ~~update ci to include code coverage after #1215~~ Update ci to include code coverage after #1215 Jan 11, 2020

timja merged commit abfc695 into jenkinsci:master Jan 11, 2020

jetersen deleted the fix/aggregateReport branch January 11, 2020 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ci to include code coverage after #1215 #1241

Update ci to include code coverage after #1215 #1241

jetersen commented Dec 27, 2019

oleg-nenashev left a comment

jetersen commented Dec 27, 2019

oleg-nenashev left a comment

jetersen commented Jan 10, 2020 •

edited

jetersen commented Jan 10, 2020

codecov bot commented Jan 10, 2020 •

edited

jetersen commented Jan 11, 2020

jetersen commented Jan 11, 2020

Update ci to include code coverage after #1215 #1241

Update ci to include code coverage after #1215 #1241

Conversation

jetersen commented Dec 27, 2019

Your checklist for this pull request

oleg-nenashev left a comment

Choose a reason for hiding this comment

jetersen commented Dec 27, 2019

oleg-nenashev left a comment

Choose a reason for hiding this comment

jetersen commented Jan 10, 2020 • edited

jetersen commented Jan 10, 2020

codecov bot commented Jan 10, 2020 • edited

Codecov Report

jetersen commented Jan 11, 2020

jetersen commented Jan 11, 2020

jetersen commented Jan 10, 2020 •

edited

codecov bot commented Jan 10, 2020 •

edited