Prevent null pointer when exporting file credentials #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
reviewed
Feb 22, 2020
| Object value = a.getValue(instance); | ||
| if (value != null) { | ||
| Object converted = Stapler.CONVERT_UTILS.convert(value, a.getType()); | ||
| if (converted instanceof Collection || p.getType().isArray() || !a |
There was a problem hiding this comment.
This needs to be formatted differently it looks odd.
jetersen
approved these changes
Feb 22, 2020
|
Build fails due to upper bound deps. |
|
sorted |
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
=========================================
Coverage 78.83% 78.83%
Complexity 780 780
=========================================
Files 65 65
Lines 2301 2301
Branches 320 320
=========================================
Hits 1814 1814
Misses 386 386
Partials 101 101 |
|
(this previously passed, re-triggering) |
|
I've been waiting for jenkinsci/credentials-plugin#135 to be merged and released as we're currently depending on an incremental version in the integration tests cc @jvz |
|
I've published credentials 2.3.2 @timja |
|
@jvz I think you forgot to merge the PR: jenkinsci/credentials-plugin#135 😱 |
|
Womp womp. Publishing 2.3.3 right now as well as an updated changelog in it. |
|
👏 |
jglick
reviewed
Mar 9, 2020
| @@ -67,6 +67,31 @@ public void testDomainScopedCredentials() { | |||
| assertEquals("secret", creds.get(0).getPassword().getPlainText()); | |||
| } | |||
|
|
|||
| @Test | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires jenkinsci/credentials-plugin#135
Fixes #1170
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.