Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop hiding credentials configuration category #1752

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Stop hiding credentials configuration category #1752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions ...a/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
public class GlobalConfigurationCategoryConfigurator extends BaseConfigurator<GlobalConfigurationCategory> implements RootElementConfigurator<GlobalConfigurationCategory> {

private static final Logger LOGGER = Logger.getLogger(GlobalConfigurationCategoryConfigurator.class.getName());
private static final String CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION = "com.cloudbees.plugins.credentials.CredentialsProviderManager$Configuration";

private final GlobalConfigurationCategory category;

Expand Down Expand Up @@ -122,14 +121,7 @@ private void describe(Descriptor d, Mapping mapping, ConfigurationContext contex
}

private boolean filterDescriptors(Descriptor d) {
if (d.clazz.getName().equals(CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION)) {
// CREDENTIALS_PROVIDER_MANAGER_CONFIGURATION is located in the wrong category.
// JCasC will also turn the simple name into empty string
// It should be a part of the credentials root configurator node.
return false;
} else {
return d.getCategory() == category && d.getGlobalConfigPage() != null;
}
return d.getCategory() == category && d.getGlobalConfigPage() != null;
}

}