Fix for JENKINS-20319 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rate emails... for Email notification The configurationslicing plugin now only disables core mailers, if - the recipient list is set to empty, and the notify individuals... checkbox is unchecked. - the recipient list is explicitly set to "(Disabled)" (case-insensitive) via the configuration slicer. Email notifications using the email-ext plugin still suffer from this error.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I could only get this configuration (updating to 1.509.2) to work in my environment if I also updated the required version of email-ext in the POM to be 2.29 (the version which was produced to update its own LTS to 1.509.1). I guess this might then cause some unexpected problems where others upgrade the configuration slicing plugin while keeping their existing version of email-ext. Can you make this change too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configurationslicing plugin now only disables mailers, if
When setting the recipient list to an empty value via the configuration slicer, email notifications sent to individual developers remain untouched.