[FIXED JENKINS-181929] Added ability to push labels with page data.

[ribrewguy]

No description provided.

[buildhive]

Jenkins » confluence-publisher-plugin #15 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[jhansche]

FYI, there is a StringUtils.isEmpty(String) method (being used elsewhere in this file) that simplifies this condition. I don't believe isEmpty() will check the trimmed length, but there is a similar StringUtils.isBlank(String) that "Checks if a String is whitespace, empty ("") or null."

[jhansche]

Looks good, thanks! Since this is a V2 API method, it would be helpful to add a check that the remote server is a V2 server, and maybe hide the option if it's not, or log a warning at runtime to indicate that labels are not supported. The end result would be something like this in addLabels():

if (this.serviceV2 == null) {
    throw new OperationNotSupportedException("Labels are supported as of Confluence v4 and later.");
}

then catch ONSE when the publisher is trying to apply the labels, and append a log warning to indicate to the user that their version of Confluence does not support labels (instead of getting a non-descript NullPointerException when trying to dereference this.serviceV2, which does not explain to the user what actually went wrong).

This plugin should remain compatible with Confluence version 3 (you can test the plugin against the public Jenkins Confluence server if you want -- that server is running v3, and will fail as described above if you try to add labels). Just create a page in your own user space there and set up your dev instance to hit that server.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[ribrewguy]

Sounds good. I will update the code and resubmit.

[buildhive]

Jenkins » confluence-publisher-plugin #18 SUCCESS
This pull request looks good
(what's this?)