-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add includeBuildNumberInTargetPath
configuration parameter
#169
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
01d8d55
Add parameter appendSrcNumberToTarget
allancth 02e4fa6
Fix field name for appendSrcNumberToTarget
allancth 8420660
Incorporate suggestion
allancth bf97bef
Unit test for parameter appendSrcNumberToTarget
allancth 05b75ac
Remove trailing space from a line
MarkEWaite c16435f
Make help visible in freestyle project
MarkEWaite 2d6193e
Change parameter name to includeBuildNumberInTargetPath + update unit…
allancth 785b692
Change parameter name to includeBuildNumberInTargetPath + update unit…
allancth 75f9582
Merge branch 'master' of github.com:allancth/copyartifact-plugin
allancth adb22b1
Change wordings: *Append* to *Include*
allancth 7c53835
Update parameter name
allancth 1f0a02d
One more phrasing change
MarkEWaite 1063876
Match help file name to field name
MarkEWaite c322d9c
Merge branch 'master' into allancth/master
MarkEWaite File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,6 @@ Artifacts\ to\ copy=\u30B3\u30D4\u30FC\u3059\u308B\u6210\u679C\u7269 | |
Artifacts\ not\ to\ copy=\u30b3\u30d4\u30fc\u3057\u306a\u3044\u6210\u679c\u7269 | ||
Target\ directory=\u30B3\u30D4\u30FC\u5148\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA | ||
Flatten\ directories=\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA\u69CB\u9020\u3092\u7121\u8996 | ||
Optional=\u30AA\u30D7\u30B7\u30E7\u30F3 | ||
Optional=\u30AA\u30D7\u30B7\u30E7\u30F3 | ||
Fingerprint\ Artifacts= | ||
Include\ Build\ Number= | ||
Comment on lines
+8
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above. |
7 changes: 7 additions & 0 deletions
7
...sources/hudson/plugins/copyartifact/CopyArtifact/help-includeBuildNumberInTargetPath.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<div> | ||
Include build number in target path. Default is false. | ||
<p> | ||
When true, the build number of the source project will be included in the target path. | ||
This is particularly useful when the selector is specific and the value is a permalink, e.g. lastSuccessfulBuild. | ||
</p> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,23 @@ | ||
<div> | ||
Select "Flatten directories" to ignore the directory structure of the artifacts | ||
<p> | ||
Select "<strong>Flatten directories</strong>" to ignore the directory structure of the artifacts | ||
in the source project and copy all matching artifacts directly into the specified | ||
target directory. By default the artifacts are copied in the same directory | ||
structure as the source project. | ||
<p/> | ||
Select "Optional" to allow this build to continue even if no build is found | ||
</p> | ||
<p> | ||
Select "<strong>Optional</strong>" to allow this build to continue even if no build is found | ||
matching the "Which build" condition selected above, the build's workspace does | ||
not exist or is inaccessible, or no artifacts are found matching the specified | ||
pattern. By default this build step fails the build if no artifacts are copied. | ||
<p/> | ||
Select "Fingerprint Artifacts" to automatically fingerprint all artifacts | ||
</p> | ||
<p> | ||
Select "<strong>Fingerprint Artifacts</strong>" to automatically fingerprint all artifacts | ||
that are copied as part of this build step. | ||
</p> | ||
<p> | ||
Select "<strong>Include Build Number</strong>" to include the source build number in the target path. | ||
When true, the build number of the source project will be included in the target path. | ||
This is particularly useful when the selector is specific and the value is a permalink, e.g. lastSuccessfulBuild. | ||
</p> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will translate the strings to an empty string. Almost certainly not what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-beck . I saw that in the code review and wondered about it. When I searched through Jenkins core and saw a number of message properties that were assigned an empty value, I thought that it must be a pattern that caused the property to be assigned the value from the default language.
An example:
https://github.com/jenkinsci/jenkins/blob/a530a99926940cb37fd2f7b66e5c2f458254a710/core/src/main/resources/hudson/logging/LogRecorder/configure_fr.properties#L24
Another example:
https://github.com/jenkinsci/jenkins/blob/a530a99926940cb37fd2f7b66e5c2f458254a710/core/src/main/resources/hudson/model/RunParameterDefinition/config_fr.properties#L24
Is the preferred pattern to leave the untranslated key out of the localized property file or is there a better way to handle it?
In this case, the best way to handle it may be to transition this plugin to use CrowdIn for its localization. That will allow translators to submit messages through the CrowdIn user interface rather than directly editing property files.
@allancth would you like to submit the pull request to remove the untranslated properties or would you prefer that I do it so that you can approve the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allancth I submitted:
If you approve and merge, it should result in a new release with a changelog that includes the bug fix.