[JENKINS-65398] Terminology update

[twasyl]

The changes introduce terminology updates to replace master by controller and remaining slave by agent.
This is lead by JENKINS-65398.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[amuniz]

@jvz you are listed as maintainer in this repository, could we get a review/merge/release of this please?

[jvz]

Yeah, I thought I already approved to auto-merge this. Is that junit error legit?

[twasyl]

Yeah, I thought I already approved to auto-merge this. Is that junit error legit?

I updated comments and help message. From reading the logs, it seems some artifacts couldn't be retrieved ending up with an Caused by: javax.net.ssl.SSLException: Connection reset

[jvz]

Build error appears to be jenkins-infra related. The file path is deleting the c in the ...\credentials-plugin part of the filename somewhere.

[twasyl]

So can this be merged? I think auto merge won't work as the junit step is not passing.

[jvz]

There's no merge button on this repo anymore. @jglick?

[jglick]

The file path is deleting the c in the ...\credentials-plugin part of the filename somewhere.

No, that is normal, unrelated. The error can be seen in https://ci.jenkins.io/job/Plugins/job/credentials-binding-plugin/job/PR-128/7/execution/node/60/log/ and does indeed look like an infra problem @MarkEWaite et al.:

Cannot contact aci-maven-windows-rnr4r: java.lang.InterruptedException

I have recently run into constant problems with these agents, prompting me to shun them: jenkinsci/file-parameters-plugin#44

[jglick]

Now the Windows build is hanging during startup in one test:

"TCP agent connection handler #12 with /10.244.243.248:49860" Id=573 Group=main RUNNABLE
	at java.math.BigInteger.implMulAdd(BigInteger.java:3047)
	at java.math.BigInteger.mulAdd(BigInteger.java:3018)
	at java.math.BigInteger.montReduce(BigInteger.java:2967)
	at java.math.BigInteger.implMontgomeryMultiply(BigInteger.java:2709)
	at java.math.BigInteger.montgomeryMultiply(BigInteger.java:2661)
	at java.math.BigInteger.oddModPow(BigInteger.java:2857)
	at java.math.BigInteger.modPow(BigInteger.java:2603)
	at io.github.stephenc.crypto.sscg.internal.bc.crypto.engines.RSACoreEngine.processBlock(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.crypto.engines.RSABlindedEngine.processBlock(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.crypto.encodings.PKCS1Encoding.encodeBlock(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.crypto.encodings.PKCS1Encoding.processBlock(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.crypto.signers.RSADigestSigner.generateSignature(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.operator.bc.BcSignerOutputStream.getSignature(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.operator.bc.BcContentSignerBuilder$1.getSignature(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.cert.CertUtils.generateSig(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.cert.CertUtils.generateFullCert(Unknown Source)
	at io.github.stephenc.crypto.sscg.internal.bc.cert.X509v3CertificateBuilder.build(Unknown Source)
	at io.github.stephenc.crypto.sscg.SelfSignedCertificate.generate(SelfSignedCertificate.java:169)
	at org.jenkinsci.main.modules.instance_identity.InstanceIdentity.getCertificate(InstanceIdentity.java:155)
	-  locked org.jenkinsci.main.modules.instance_identity.InstanceIdentity@55e42449
	at org.jenkinsci.main.modules.instance_identity.InstanceIdentityRSAProvider.getCertificate(InstanceIdentityRSAProvider.java:48)
	at jenkins.model.identity.InstanceIdentityProvider$KeyTypes.getCertificate(InstanceIdentityProvider.java:284)
	at jenkins.slaves.JnlpSlaveAgentProtocol4.<init>(JnlpSlaveAgentProtocol4.java:103)

I guess I just need to give up on testing anything on Windows.

[jglick]

⇒ #129

[jglick]

Merge in master and this ought to work I guess.

[kerogers-cloudbees]

@jvz Can we get a release of this plugin including these changes? Thanks!

[jglick]

Still trying to get a review of #132.

[jglick]

in https://github.com/jenkinsci/credentials-binding-plugin/releases/tag/credentials-binding-1.25