[JENKINS-44860] Honor secret setting for username #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `set +x` will avoid any console output, so the tests didn't actually test anything, as no credentials was logged masked or not. Same goes for `@echo off` for Windows
To avoid findbugs to fail the build. Used the same value as used in the other serializable classes.
…ding-plugin into show-username-JENKINS-44860
…ding-plugin into show-username-JENKINS-44860
This was referenced Jun 2, 2021
bitwiseman
approved these changes
Jun 2, 2021
…ding-plugin into show-username-JENKINS-44860-alt
This was referenced Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #131 which puts the control in the hands of those defining the credentials rather than consuming them. Downstream of jenkinsci/credentials-plugin#205 and will also work well with jenkinsci/ssh-credentials-plugin#70 if that is installed.