Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-44860] Honor secret setting for username #132

Merged
merged 18 commits into from
Jun 2, 2021
Merged

[JENKINS-44860] Honor secret setting for username #132

merged 18 commits into from
Jun 2, 2021
+141 −41

Commits on Jul 13, 2018

  1. The username in a UsernamePasswordMultiBinding should not be consider… 

    …ed sensitive.
    @Stovoy @henrist
    Stovoy authored and henrist committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    b9022fe View commit details
    Browse the repository at this point in the history

  2. Resolves issues in previous commit from PR jenkinsci#44

    @henrist
    henrist committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    6616629 View commit details
    Browse the repository at this point in the history

  3. Add positive test for username and fix test log output 

    - `set +x` will avoid any console output, so the tests didn't actually
  test anything, as no credentials was logged masked or not.
  Same goes for `@echo off` for Windows
    @henrist
    henrist committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    506c651 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2018

  1. Set serialVersionUID for MultiEnvironment 

    To avoid findbugs to fail the build. Used the same value as used in the
other serializable classes.
    @henrist
    henrist committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    fcd36ce View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge branch 'master' of https://github.com/jenkinsci/credentials-bin… 

    …ding-plugin into show-username-JENKINS-44860
    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b18f91c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/jenkinsci/credentials-bin… 

    …ding-plugin into show-username-JENKINS-44860
    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    61be7c3 View commit details
    Browse the repository at this point in the history

  3. Verify that secretValues and publicValues do not intersect

    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c9f6efe View commit details
    Browse the repository at this point in the history

  4. Making new behavior opt-in via showUsername field

    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    20044b5 View commit details
    Browse the repository at this point in the history

  5. When !showUsername, retain order usernameVariable then `passwordV… 

    …ariable`
    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9e330b0 View commit details
    Browse the repository at this point in the history

  6. Minimize diff in BindingStep

    @jglick
    jglick committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c838e6f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. [JENKINS-44860] Honor secret setting for username

    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    58de8ca View commit details
    Browse the repository at this point in the history

  2. Masking message from BindingStep incorrectly named nonsecret keys

    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6efdc19 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'show-username-JENKINS-44860' into show-username-JENKINS… 

    …-44860-alt
    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    8cf5a0e View commit details
    Browse the repository at this point in the history

  4. Adjusted BindingStepTest.basics to match

    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    e75b52b View commit details
    Browse the repository at this point in the history

  5. Bump

    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    a9c68b7 View commit details
    Browse the repository at this point in the history

  6. Javadoc fix

    @jglick
    jglick committed May 6, 2021
    Configuration menu
    Copy the full SHA
    4fe1b94 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Merge branch 'master' of https://github.com/jenkinsci/credentials-bin… 

    …ding-plugin into show-username-JENKINS-44860-alt
    @jglick
    jglick committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    5eba5f6 View commit details
    Browse the repository at this point in the history

  2. credentials 2.5 released

    @jglick
    jglick committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    cb242b0 View commit details
    Browse the repository at this point in the history