New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-20139] Inaccurate/incomplete Javadoc for track
overloads
#70
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to highlight that the node tracking is for launching an agent not from a build
@@ -1444,7 +1444,7 @@ public static Fingerprint getOrCreateFingerprintOf(@NonNull Credentials c) throw | |||
} | |||
|
|||
/** | |||
* Track the usage of credentials in a specific build | |||
* Track the usage of credentials in a specific node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the comment on launching an agent
@@ -1461,7 +1461,7 @@ public static Fingerprint getOrCreateFingerprintOf(@NonNull Credentials c) throw | |||
} | |||
|
|||
/** | |||
* Track the usage of credentials in a specific build | |||
* Track the usage of credentials in a specific node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the comment on launching an agent
@@ -1461,7 +1461,7 @@ public static Fingerprint getOrCreateFingerprintOf(@NonNull Credentials c) throw | |||
} | |||
|
|||
/** | |||
* Track the usage of credentials in a specific build | |||
* Track the usage of credentials in a specific node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. Launching an agent
Amends #58. Noticed from jenkinsci/credentials-binding-plugin#27.
@reviewbybees esp. @stephenc