Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add packager-download service #58

Merged
merged 9 commits into from
Jul 15, 2020
Merged

Add packager-download service #58

merged 9 commits into from
Jul 15, 2020

Conversation

sladyn98
Copy link
Contributor

This PR adds the packager-config.yml download feature, and also fixes the nav-links.

@sladyn98 sladyn98 requested a review from a team as a code owner June 29, 2020 08:04
@sladyn98
Copy link
Contributor Author

sladyn98 commented Jul 6, 2020

@kwhetstone https://ci.jenkins.io/blue/organizations/jenkins/Tools%2Fcustom-distribution-service/detail/PR-58/2/pipeline
It seems to stop at the archiving tests, I cannot quite understand why, even though it is running on a linux system now

martinda
martinda suggested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Sladyn, I am done my review. I do not know react very much, so I focused on the Java instead.

frontend/src/components/PackageGeneration/Editor.js Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/util/Util.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/util/Util.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Outdated Show resolved Hide resolved
@kwhetstone
Copy link
Contributor

@sladyn98 When that's the failing step, it's better to go back to the previous phase to see if there was a masked hidden failure. In this job, it's failing to even run the maven commands since it can't find the package.json

@sladyn98 sladyn98 requested a review from martinda July 9, 2020 09:29
LinuxSuRen
LinuxSuRen suggested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Outdated Show resolved Hide resolved
martinda
martinda suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An easy small fix, but important nevertheless. Good names are important because they enhance discoverability and search results.

frontend/src/components/PackageGeneration/Editor.js Outdated Show resolved Hide resolved
martinda
martinda suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR has the Util.java, the other PR (#68) could use it. So I suggest getting this one in first.

...va/com/org/jenkins/custom/jenkins/distribution/service/services/PackagerDownloadService.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Outdated Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Show resolved Hide resolved
martinda added a commit to martinda/custom-distribution-service that referenced this pull request Jul 14, 2020
@martinda
Improve javadoc for PR jenkinsci#58
c441da4
kwhetstone
kwhetstone suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that adding comments and potentially figuring out what's going on in the plugins in the pom are going to be the most important pieces of getting this merged. After those changes are added, I'll change to approve.

frontend/src/components/PackageGeneration/Editor.js Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/PackagerController.java Show resolved Hide resolved
src/main/java/com/org/jenkins/custom/jenkins/distribution/service/util/Util.java Outdated Show resolved Hide resolved
src/test/resources/packagerConfig/simpleConfig.yml Show resolved Hide resolved
@martinda
Copy link
Contributor

Looks good to me! I have no further comments on this PR. Thanks @sladyn98

@sladyn98 sladyn98 merged commit 4db7c15 into jenkinsci:master Jul 15, 2020
@sladyn98 sladyn98 added the feature A PR that adds a feature label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martinda martinda martinda requested changes

@kwhetstone kwhetstone kwhetstone requested changes

@LinuxSuRen LinuxSuRen Awaiting requested review from LinuxSuRen

Assignees
No one assigned
Labels
feature A PR that adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sladyn98 @kwhetstone @martinda @LinuxSuRen