[FIXED JENKINS-32648] log the name of the node. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running print the name of the node that executes the remote command.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -124,6 +124,8 @@ public void run() { | |||
| try { | |||
| Computer c = Computer.currentComputer(); | |||
| Node n = c.getNode(); | |||
| String nodeName = n.getNodeName().equals("") ? "master" : n.getNodeName(); | |||
There was a problem hiding this comment.
no. it is @NonNull Javadoc
|
Would be also useful to have a test for runs on master. |
@oleg-nenashev that is what If you know of a way to check that the task actually ran on a specific node I will add it (but I was not aware of one for a Task as opposed to a Run) |
|
@reviewbybees done |
jtnord
added a commit
that referenced
this pull request
Feb 10, 2016
[FIXED JENKINS-32648] log the name of the node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running print the name of the node that executes the remote command.
JENKINS-32648
@reviewbybees