chore(updatecli) Fix JDK manifests to use the proper Ubuntu version #762
Conversation
…architecture. For docker images.
gounthar
changed the title
updatecli/updatecli.d/jdk21.yaml
Outdated
| @@ -51,44 +51,44 @@ conditions: | |||
| tag: '{{ source "getLatestJDK21Version" }}-jdk-alpine' | |||
| checkTemurinDebianDockerImages: | |||
| kind: dockerimage | |||
| name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available | |||
| name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-jammy" is available | |||
| disablesourceinput: true | |||
| spec: | |||
| architectures: | |||
| - amd64 | |||
There was a problem hiding this comment.
Don't you need OS here as well? That is:
- linux/amd64
- linux/arm64
This would apply to the checkTemurinAlpineDockerImage above as well.
There was a problem hiding this comment.
No, as in the documentation, I can read:
The default operating system is linux.
There was a problem hiding this comment.
Ah, right. Doesn't hurt, but isn't necessary.
There was a problem hiding this comment.
Yes, doesn't hurt, it's some kind of "the documentation is the code". 👍
|
Got a 503, as the #761. |
|
Now it builds! 🚀 |
|
@gounthar can you resolve the conflicts in this that came from my merge of |
|
It's done. |
gounthar
changed the title
There was a problem hiding this comment.
Run Summary
===========
Pipeline(s) run:
* Changed: 0
* Failed: 0
* Skipped: 0
* Succeeded: 10
* Total: 10
LGTM!
Food for though (for another PR): we should be able to add a 2nd source to updatecli manifest which would retrieve the current Docker image suffix (or distribution) to make it more universal. But it is nitpicking.
Moved from
focaltojammyfor JDK17/21 and added the architecture for Windows andlinux/arm/v7docker images.JDK11 will fail because of :
Testing done
updatecli diff --config ./updatecli/updatecli.d/jdk21.yaml --values ./updatecli/values.github-action.yamlupdatecli diff --config ./updatecli/updatecli.d/jdk17.yaml --values ./updatecli/values.github-action.yamlupdatecli diff --config ./updatecli/updatecli.d/jdk11.yaml --values ./updatecli/values.github-action.yamlSubmitter checklist
Link to relevant pull requests, esp. upstream and downstream changes