Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(updatecli) Fix JDK manifests to use the proper Ubuntu version #762

Merged
merged 12 commits into from
Mar 18, 2024
Merged

chore(updatecli) Fix JDK manifests to use the proper Ubuntu version #762

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a8ca97
fix(dependencies): Updatecli now needs to get more precise about the …
gounthar Mar 6, 2024
ce3ec88
Merge branch 'master' into updatecli-jdk
gounthar Mar 8, 2024
90b8d91
Merge branch 'master' into updatecli-jdk
gounthar Mar 8, 2024
4f586c3
fix(dependencies): Updatecli now needs to get more precise about the …
gounthar Mar 8, 2024
52cf689
fix(dependencies): Updatecli now needs to get more precise about the …
gounthar Mar 9, 2024
292b3de
Merge branch 'master' into updatecli-jdk
gounthar Mar 9, 2024
a981b4e
Merge branch 'master' into updatecli-jdk
gounthar Mar 12, 2024
8121797
Merge branch 'master' into updatecli-jdk
gounthar Mar 13, 2024
489a1ae
fix(dependencies): Conflicts solving.
gounthar Mar 17, 2024
7bb2a10
fix(dependencies): Conflicts solving.
gounthar Mar 17, 2024
02a3445
fix(dependencies): Conflicts solving.
gounthar Mar 17, 2024
598e08b
Merge remote-tracking branch 'upstream/master' into updatecli-jdk
gounthar Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions updatecli/updatecli.d/jdk21.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,44 +51,44 @@ conditions:
tag: '{{ source "getLatestJDK21Version" }}-jdk-alpine'
checkTemurinDebianDockerImages:
kind: dockerimage
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-jammy" is available
disablesourceinput: true
spec:
architectures:
- amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need OS here as well? That is:

  - linux/amd64
  - linux/arm64

This would apply to the checkTemurinAlpineDockerImage above as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as in the documentation, I can read:

The default operating system is linux.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Doesn't hurt, but isn't necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, doesn't hurt, it's some kind of "the documentation is the code". 👍

- arm64
image: eclipse-temurin
tag: '{{ source "getLatestJDK21Version" }}-jdk-focal'
tag: '{{ source "getLatestJDK21Version" }}-jdk-jammy'
checkTemurinNanoserver2019DockerImage:
kind: dockerimage
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-nanoserver-1809" is available
disablesourceinput: true
spec:
architecture: amd64
architecture: windows/amd64
image: eclipse-temurin
tag: '{{ source "getLatestJDK21Version" }}-jdk-nanoserver-1809'
checkTemurinWindowsCore2019DockerImage:
kind: dockerimage
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-windowsservercore-1809" is available
disablesourceinput: true
spec:
architecture: amd64
architecture: windows/amd64
image: eclipse-temurin
tag: '{{ source "getLatestJDK21Version" }}-jdk-windowsservercore-1809'
checkTemurinNanoserver2022DockerImage:
kind: dockerimage
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-nanoserver-ltsc2022" is available
disablesourceinput: true
spec:
architecture: amd64
architecture: windows/amd64
image: eclipse-temurin
tag: '{{ source "getLatestJDK21Version" }}-jdk-nanoserver-ltsc2022'
checkTemurinWindowsCore2022DockerImage:
kind: dockerimage
name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-windowsservercore-ltsc2022" is available
disablesourceinput: true
spec:
architecture: amd64
architecture: windows/amd64
image: eclipse-temurin
tag: '{{ source "getLatestJDK21Version" }}-jdk-windowsservercore-ltsc2022'

Expand Down