Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dynamic linking with Apache HttpComponents Client 5.x API plugin #63

Merged
merged 2 commits into from
May 21, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 24, 2023

This PR slims down this plugin by implementing dynamic linking with the new Apache HttpComponents Client 5.x API plugin. I have not tested this PR, and it would be a good idea to do an end-to-end/functional test before merging/releasing this. I did confirm that the .hpi file no longer has the httpclient5 or httpcore5 JARs present.

@ericcitaire ericcitaire added enhancement dependencies Pull requests that update a dependency file labels Mar 24, 2023
@basil
Copy link
Member Author

basil commented May 20, 2023

I tested this successfully by running a Pipeline job in a Docker agent with version 1.3.0 of the Jenkins Docker plugin.

@basil basil merged commit bb0c233 into jenkinsci:master May 21, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants