Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for building jenkins-ci for next version of debian #262

Closed
wants to merge 2 commits into from

Conversation

ieugen
Copy link
Contributor

@ieugen ieugen commented Jun 20, 2023

This is a replacement for #255 .

https://wiki.debian.org/DebianBookworm

Debian bookworm is releasing in ~ 10 days.
Code wise there will be no breaking changes, only bug fixes.

I believe it's time to consider publishing an updated version based on bookworm.
For our use case we need a newer release of buildah.

Testing done

make build
make test

Will push and use in our infra soon.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ieugen ieugen requested a review from a team as a code owner June 20, 2023 18:33
@ieugen
Copy link
Contributor Author

ieugen commented Jun 20, 2023

@dduportal and all: I've created a new PR based on rebased code on another branch so I will have to close this.
Let's continue discussion there.

I do think that we might have to use separate dockerfiles for different Debian releases.
The reasoning is that build instructions might be different as packages might change ?!
(just thinking out loud at this point).

Also, I've been out of the loop and don't know if I should do for the PR to be merged.
As it is now, this PR is not ready to be merged since we can't pass Debian bersion via bake to dockerfile.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Bruno Verachten <gounthar@gmail.com>
@gounthar
Copy link
Contributor

I apologize for not being able to contribute and offer assistance earlier due to my holidays and participating in GSoC.
Now that I have more time available, I would like to help and support you with that PR.
If you still need assistance, please let me know how I can be of help, and we can discuss the areas you'd like me to focus on.

@gounthar gounthar mentioned this pull request Aug 21, 2023
5 tasks
@dduportal
Copy link
Contributor

dduportal commented Sep 2, 2023

I'm closing this PR as it was superseded by #299 .

Thanks @ieugen for the help here, you did most of the heavy lifting and we are crediting this work with you along with @gounthar !

For info, it was release with https://github.com/jenkinsci/docker-ssh-agent/releases/tag/5.10.0

@dduportal dduportal closed this Sep 2, 2023
@ieugen ieugen deleted the bookworm-upgrade branch September 2, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants