Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Debian ca-certificates package #266

Merged
merged 3 commits into from Jul 3, 2023
Merged

Install Debian ca-certificates package #266

merged 3 commits into from Jul 3, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jul 3, 2023 •
edited

Install Debian ca-certificates package

  • Update npm to 9.7.2
  • Add failing test for issue 265
  • Install ca-certificates Debian package

Fixes

Testing done

Wrote an automated test that confirms the bug is repeatable, then wrote the fix and confirmed the test passes. Confirmed that the failure is only visible in the Debian containers, not in Alpine.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@MarkEWaite MarkEWaite requested a review from a team as a code owner July 3, 2023 13:50
@MarkEWaite MarkEWaite added the bug label Jul 3, 2023
@MarkEWaite MarkEWaite linked an issue Jul 3, 2023 that may be closed by this pull request
Unable to clone from Github due to ca cert missing #265
Closed
@MarkEWaite MarkEWaite merged commit d21cba7 into jenkinsci:master Jul 3, 2023
3 checks passed
@MarkEWaite MarkEWaite deleted the install-ca-certificates-for-debian branch July 3, 2023 15:04
@gounthar gounthar mentioned this pull request Jul 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to clone from Github due to ca cert missing
2 participants
@MarkEWaite @timja