Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) Track npm and node version updates #267

Merged
merged 4 commits into from Jul 3, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Jul 3, 2023

Following #266 where I saw @MarkEWaite had to update the npm version by hand, I propose to let updatecli do it for us.

Testing done

updatecli diff --debug --config updatecli/updatecli.d/npm.yaml --values updatecli/values.github-action.yaml
updatecli diff --debug --config updatecli/updatecli.d/node.yaml --values updatecli/values.github-action.yaml

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar marked this pull request as ready for review July 3, 2023 15:18
@gounthar gounthar requested a review from a team as a code owner July 3, 2023 15:18
@MarkEWaite MarkEWaite changed the title feature(updatecli) Tracks npm and node feature(updatecli) Track npm and node version updates Jul 3, 2023
@MarkEWaite MarkEWaite merged commit 4a162ae into jenkinsci:master Jul 3, 2023
3 checks passed
@dduportal dduportal changed the title feature(updatecli) Track npm and node version updates chore(updatecli) Track npm and node version updates Jul 3, 2023
@gounthar gounthar deleted the updatecli-for-npm branch July 3, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants