Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multifrom Dockerfile parsing #162

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
@bozaro
Copy link

commented Feb 1, 2019

Fix crash on Dockerfile with FROM <image>[@<digest>] AS <name>:

java.io.IOException: Cannot retrieve .Id from 'docker inspect node:current-alpine AS release'
	at org.jenkinsci.plugins.docker.workflow.client.DockerClient.inspectRequiredField(DockerClient.java:220)
	at org.jenkinsci.plugins.docker.workflow.FromFingerprintStep$Execution.run(FromFingerprintStep.java:133)
	at org.jenkinsci.plugins.docker.workflow.FromFingerprintStep$Execution.run(FromFingerprintStep.java:85)
	at 

@bozaro bozaro force-pushed the bozaro:docker-mutli-from branch from e865e13 to 96975db Feb 2, 2019

@Minipada

This comment has been minimized.

Copy link

commented Apr 18, 2019

Can a maintainer check this?

@jonesbusy

This comment has been minimized.

Copy link

commented Apr 23, 2019

Hello, yes would be nice if someone would take a look :)

Thanks!

@lyssdod

This comment has been minimized.

Copy link

commented Apr 30, 2019

anyone? :)

@jvtrigueros

This comment has been minimized.

Copy link

commented Apr 30, 2019

Two JIRA issues have been filed for this:

Please also vote on these for visibility. I don't understand what the triage process is for this project but that's the very least we can do :)

@jonesbusy

This comment has been minimized.

Copy link

commented Apr 30, 2019

Voted!

@Minipada

This comment has been minimized.

Copy link

commented May 1, 2019

i voted and commented on all 3 (yes, there's a third one JENKINS-31507) with a link to this PR already

@empyrean987

This comment has been minimized.

Copy link

commented May 3, 2019

Anyone Looking at this PR. I'm running into this issue also?

@Minipada

This comment has been minimized.

Copy link

commented May 3, 2019

I guess we all commented and voted because of this @empyrean987

@erNail

This comment has been minimized.

Copy link

commented May 3, 2019

Also running into this issue.

@Danulb

This comment has been minimized.

Copy link

commented May 3, 2019

Please check this. I have also the issue.

@knlambert

This comment has been minimized.

Copy link

commented May 7, 2019

Also running into the issue.

@derekwilliamscrosswinds

This comment has been minimized.

Copy link

commented May 8, 2019

Also running into this issue.

1 similar comment
@walkermundo

This comment has been minimized.

Copy link

commented May 13, 2019

Also running into this issue.

@cosi1

This comment has been minimized.

Copy link

commented May 14, 2019

Piggybacking on this thread:

This issue also happens when nested variables are used after FROM statement. Example:

ARG REPOSITORY=my_repository/
ARG NAME=${REPOSITORY}base
ARG VERSION=latest
FROM ${NAME}:${VERSION}
...

The above will crash with an unresolved base image name (${REPOSITORY}base instead of my_repository/base):

java.io.IOException: Cannot retrieve .Id from 'docker inspect ${REPOSITORY}base:latest'
@Minipada

This comment has been minimized.

Copy link

commented May 14, 2019

Yes, the reason is that the plugin saves the container image as everything after character 5. Please upvote the thread on the links

@bozaro

This comment has been minimized.

Copy link
Author

commented May 29, 2019

@dwnusbaum, please view this PR and comment something...

@praves77

This comment has been minimized.

Copy link

commented May 29, 2019

Also running into this issue.

@monsterxx03

This comment has been minimized.

Copy link

commented Jun 3, 2019

Even you didn't use multi stage build, just enter more than 1 space after FROM will see same error, take long time to debug.....

@jessecooper

This comment has been minimized.

Copy link

commented Jun 6, 2019

This would be really nice to have about now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.