-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multifrom Dockerfile parsing #162
Conversation
e865e13
to
96975db
Compare
Can a maintainer check this? |
Hello, yes would be nice if someone would take a look :) Thanks! |
anyone? :) |
Two JIRA issues have been filed for this: Please also vote on these for visibility. I don't understand what the triage process is for this project but that's the very least we can do :) |
Voted! |
i voted and commented on all 3 (yes, there's a third one JENKINS-31507) with a link to this PR already |
Anyone Looking at this PR. I'm running into this issue also? |
I guess we all commented and voted because of this @empyrean987 |
Also running into this issue. |
Please check this. I have also the issue. |
Also running into the issue. |
Also running into this issue. |
1 similar comment
Also running into this issue. |
Piggybacking on this thread: This issue also happens when nested variables are used after
The above will crash with an unresolved base image name (
|
Yes, the reason is that the plugin saves the container image as everything after character 5. Please upvote the thread on the links |
@dwnusbaum, please view this PR and comment something... |
Also running into this issue. |
Even you didn't use multi stage build, just enter more than 1 space after |
This would be really nice to have about now. |
This breaks on the vanilla dockerfile generated by Visual Studio. This should've been fixed and released long ago. Is there an ETA for the release of this? |
@dwnusbaum This needs to get shipped - multicontainer builds cannot be thrown out the window because of this and while a workaround exists, it has to be coded for specifically in each job. If images later become multi-stage in a job they will start failing. |
Please look into this, still we are getting same issue, |
Same error here: The only workaround I can think of right now is stopping using this plugin and manually running Docker commands with |
I face the same error here but the problem was the spaces between the
Thanks @monsterxx03 |
I do not recommend trying to fix this sort of thing per se. See #149 (comment). |
I went ahead and created a PR to remove the line: #180 |
The code modified in this PR was deprecated by #180 and will no longer be called in normal usage in the next release (1.19), so I am closing it. Please reopen the PR if I missed something and this code still matters for use cases outside of |
We're still hitting this issue with docker-workflow 1.19, docker plugin 1.1.7 and Jenkins 2.176.2:
Dockerfile:
I can see that the deprecated code is still called for some reason. Thoughts? |
Whats in your Jenkinsfile? |
Here it is:
|
Okay, this is a totally different code-path :) It looks to be this line to me: https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/31569c0385f555f0b3146c68eb748a5dcf16efd6/pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy#L73 Not sure what's best here, but I will open a PR. |
I opened the PR: jenkinsci/pipeline-model-definition-plugin#350 |
Fix crash on Dockerfile with
FROM <image>[@<digest>] AS <name>
: