Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExitLifecycle when running in a container (#1268) #1270

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

timja
Copy link
Member

@timja timja commented Jan 11, 2022

Reverts #1269

@timja timja requested a review from a team as a code owner January 11, 2022 20:53
@MarkEWaite MarkEWaite changed the title Use ExitLifecycle when running in a container (#1268)" Revert "Use ExitLifecycle when running in a container (#1268)" Jan 11, 2022
@MarkEWaite MarkEWaite changed the title Revert "Use ExitLifecycle when running in a container (#1268)" Use ExitLifecycle when running in a container (#1268) Jan 11, 2022
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay. I was not paying enough attention to this one.

@timja timja enabled auto-merge (squash) April 7, 2022 14:34
@timja timja merged commit b6e8dd2 into master Apr 8, 2022
@timja timja deleted the revert-1269-revert-exit branch April 8, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants