Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finished date to copy_reference_file.log #1905

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jonesbusy
Copy link
Contributor

I'm unvestigating some issue with one of my controller that the copy reference function take much more time that usual. It's probably due to something in my infra.

In order to compare timeout I would like to have the end date/time when reference are copied into the volume.

The copy_reference_file.log already contains the start date/time and would be useful to also have the end time

Testing done

Didn't test but I don't expect any side effect for adding a log

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner July 16, 2024 12:49
@MarkEWaite
Copy link
Contributor

Isn't that information already available from the last modified date of the file?

I don't object to writing the date to the log as well, but it seems that you can already obtain that information with either stat or ls-L. A stackoverflow article discusses the complexities of file modification times

@jonesbusy
Copy link
Contributor Author

I'm also interested by the history (when the container is upgraded/recreated). It's personally also easier for me to just grab all the log file and perform some comparaison across my controller

@timja timja merged commit 374b395 into jenkinsci:master Jul 16, 2024
12 checks passed
@jonesbusy jonesbusy deleted the feature/add-logs branch July 16, 2024 15:08
@jonesbusy
Copy link
Contributor Author

This was caused by many service in one of my namespace causing slowing then bash environment contains too much environment variables

I've open a PR on jenkinsci/helm-charts#1191 to allow disable service links if required

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants