Fix install-plugins.sh for update-center changes #964
Conversation
This uses the ?version= URL to determine the version specific update center. This is the canonical way to get the version specific update center, if one exists. Otherwise, it will return the update center for the latest.
slide
changed the title
slide
changed the title
| @@ -245,8 +245,9 @@ main() { | |||
|
|
|||
| # Check if there's a version-specific update center, which is the case for LTS versions | |||
| jenkinsVersion="$(jenkinsMajorMinorVersion)" | |||
| if curl -fsL -o /dev/null "$JENKINS_UC/$jenkinsVersion"; then | |||
| JENKINS_UC_LATEST="$JENKINS_UC/$jenkinsVersion" | |||
| jenkinsUcJson=$(curl -Ls -o /dev/null -w "%{url_effective}" "${JENKINS_UC}/update-center.json?version=${jenkinsVersion}") | |||
There was a problem hiding this comment.
Clever, but still relies on internals, specifically the directory structure inside tiered update sites and the existence of latest/ directories in them (#953).
Personally I'd prefer if we could replace that by parsing the returned JSON, but I can understand if you want to put that off.
There was a problem hiding this comment.
I would like not parse the JSON in a shall script and replace install-plugins.sh with the plugin-installation-manager-tool, but I am not sure how feasible that is at this point.
There was a problem hiding this comment.
With jq it's straightforward enough, but I don't know whether that is a reasonable dependency to add here.
There was a problem hiding this comment.
We would have to add it to each image type. I would prefer to hold off and just use the new tool that we want to move to anyway.
|
Any news here? |
|
Looks like some test failures, let me look at them today. |
|
Looks like test failures are intermittent? |
|
@MarkEWaite any issues with this? |
|
No issues from me @slide |
This uses the ?version= URL to determine the version specific update center. This is the canonical way to get the version specific update center, if one exists. Otherwise, it will return the update center for the latest.
cc @daniel-beck