Fix the error in the test wrapper discovered by the test

jenkinsci · Aug 13, 2015 · 0a5fd20 · 0a5fd20
1 parent 660f00d
commit 0a5fd20
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginConfiguration.java b/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginConfiguration.java
@@ -85,11 +85,9 @@ protected XmlFile getConfigFile() {
 
     @Override
     public boolean configure(StaplerRequest req, JSONObject json) throws FormException {
-        this.enablePermissions = json.getBoolean("enablePermissions");
-        this.hideInjectedVars = json.getBoolean("hideInjectedVars");
-        EnvInjectPlugin.getInstance().onConfigChange(this);
-        save();
-        return true;
+        final boolean newEnablePermissions = json.getBoolean("enablePermissions");
+        final boolean newHideInjectedVars = json.getBoolean("hideInjectedVars");
+        return configure(newHideInjectedVars, newEnablePermissions);
     }
 
     /**
@@ -107,6 +105,7 @@ public boolean configure(StaplerRequest req, JSONObject json) throws FormExcepti
         }
         instance.hideInjectedVars = hideInjectedVars;
         instance.enablePermissions = enablePermissions;
+        EnvInjectPlugin.getInstance().onConfigChange(instance);
         instance.save();
         return true;
     }