added option for disallowing system groovy script

[michael1010]

when using a permission model and an user has just the job configure and
job run permission the system groovy script choice parameter would allow
the user to bypass the permissions and do everything he wants via the
groovy script
this commit adds a checkbox in the global jenkins configuration to
disallow system groovy scripts as choice parameter

[ikedam]

Rather we'd better to introduce Script Security plugin.
It provides more reliable permission controls for administrators.

[ikedam]

• Integrating Script security plugin may take much time (especially weiting tests).
• There are also a security issue with FilenameChoiceListProvider. (JENKINS-26721).

For above reasons, I plan to introduce a feature for administrators to enable / disable each ChoiceListProvider in the system configuration page.
But now I don't have time to start that work. It may take some time for that feature.

[michael1010]

Feel free to take this pull request as a starting point.
I simply have added a checkbox to the system configuration page.
Once the checkbox is checked the System Groovy Script ChoiceListProvider
will disappear from the choice dropdown in the job configuration
however it is still possible to run old jobs that have configured the
System groovy script even if the checkbox is checked

On 03/08/2015 04:01 PM, ikedam wrote:

• Integrating Script security plugin
  https://wiki.jenkins-ci.org/display/JENKINS/Script+Security+Plugin
  may take much time (especially weiting tests).
• There are also a security issue with |FilenameChoiceListProvider|.
  (JENKINS-26721 https://issues.jenkins-ci.org/browse/JENKINS-26721).

For above reasons, I plan to introduce a feature for administrators to
enable / disable each |ChoiceListProvider| in the system configuration
page.
But now I don't have time to start that work. It may take some time
for that feature.

—
Reply to this email directly or view it on GitHub
#11 (comment).

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[ikedam]

@michael1010
Sorry for my late work.
I created #12 replacing this request.
I want your review and comments for that if you don't mind.

[ikedam]

Merged #12 instead.