Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option for disallowing system groovy script #11

Closed
wants to merge 1 commit into from

Conversation

michael1010
Copy link

when using a permission model and an user has just the job configure and
job run permission the system groovy script choice parameter would allow
the user to bypass the permissions and do everything he wants via the
groovy script
this commit adds a checkbox in the global jenkins configuration to
disallow system groovy scripts as choice parameter

when using a permission model and an user has just the job configure and
job run permission the system groovy script choice parameter would allow
the user to bypass the permissions and do everything he wants via the
groovy script
this commit adds a checkbox in the global jenkins configuration to
disallow system groovy scripts as choice parameter
@ikedam
Copy link
Member

ikedam commented Mar 8, 2015

Rather we'd better to introduce Script Security plugin.
It provides more reliable permission controls for administrators.

@ikedam
Copy link
Member

ikedam commented Mar 8, 2015

For above reasons, I plan to introduce a feature for administrators to enable / disable each ChoiceListProvider in the system configuration page.
But now I don't have time to start that work. It may take some time for that feature.

@michael1010
Copy link
Author

Feel free to take this pull request as a starting point.
I simply have added a checkbox to the system configuration page.
Once the checkbox is checked the System Groovy Script ChoiceListProvider
will disappear from the choice dropdown in the job configuration
however it is still possible to run old jobs that have configured the
System groovy script even if the checkbox is checked

On 03/08/2015 04:01 PM, ikedam wrote:

For above reasons, I plan to introduce a feature for administrators to
enable / disable each |ChoiceListProvider| in the system configuration
page.
But now I don't have time to start that work. It may take some time
for that feature.


Reply to this email directly or view it on GitHub
#11 (comment).

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ikedam
Copy link
Member

ikedam commented Apr 26, 2015

@michael1010
Sorry for my late work.
I created #12 replacing this request.
I want your review and comments for that if you don't mind.

@ikedam
Copy link
Member

ikedam commented May 15, 2015

Merged #12 instead.

@ikedam ikedam closed this May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants