Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bom sshd #443

Closed
wants to merge 5 commits into from
Closed

Bom sshd #443

wants to merge 5 commits into from

Conversation

kuisathaverat
Copy link
Contributor

This PR change to use BOM to manage the dependencies of the plugin and changes to use Apache Mina sshd 1.7.0 directly because is no longer in the Jenkins core after 2.282. This is related to the changes described on JENKINS-60902 to bump the Apache Mina SSHD library.

related to jenkinsci/sshd-plugin#45 and #441
see Jenkins Core BOM

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

cc @rsandell

@kuisathaverat kuisathaverat mentioned this pull request Jun 6, 2021
Merged
6 tasks
@rsandell
Copy link
Member

I took some inspiration from this when I merged #435
Hopefully that will help bumping to even newer core dependency.

@kuisathaverat
Copy link
Contributor Author

we can close this one too :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuisathaverat @rsandell