[JENKINS-55284] Force update existing tags #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the parameterized GitClientTest to run the test on all three implementations (git, jgit, and jgitapache). Allow the test randomization in GitClientTest to intentionally vary fetch parameters.
Adapt plugin to CLI git 2.20.0 bug fix. The git fetch behavior prior to git 2.20.0 was to update existing tags without requiring a --force. The newer versions require --force to update existing tags. Retain existing behavior for earlier versions, only use the --force option to fetch for new versions of command line git. Previous fix that was included in git client plugin 2.7.5 is necessary but not sufficient. There are two different paths to `git fetch` and the earlier change only modified one of those two paths. This modifies the second.
The parameterized tests in GitClientTest better cover the case than this test and are more likely to detect problems than this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the test in the GitClientTest parameterized test class so that it will be tested on all three implementations and will test with the intentionally randomized fetch parameters.