-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JENKINS-24786] Environment variables are not expanded in git publisher
Fix: Git publisher fails if remote repository configuration contains environment variables
- Loading branch information
Showing
3 changed files
with
91 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkEWaite Any chance we can get a new release soon with this patch included? I'm trying to set up parameterized builds for auto-deploy to heroku and this is a blocker on the publishing side.
Keep up the great work!
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A version of the plugin containing this change will likely release in a week or less.
Have you confirmed (with a pre-release build) that the change meets your needs? If not, would you be willing to test drive a pre-release if one were available within the next few days?
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tried building the plugin myself, no. I just recently installed jenkins on AWS and am trying it out for auto-deploy. I tried updating from 2.2.10 to 2.3.2 to see if it resolved the issue. It didn't, so I glanced at the code and saw this recent patch was committed after the 2.3.2 release and appears to resolve the issue. I'd be happy to give a pre-release version a try if one is made available.
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git-plugin 2.3.3 and later includes this change
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I actually built it a couple days ago and installed it, just upgraded to the official release. This resolves the issue I was seeing but now I'm hitting the timeout identified here: https://issues.jenkins-ci.org/browse/JENKINS-23476
Gonna see if I can make a quick patch for it, if it's a lot of effort I might have to go with a different approach.
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout on clone can be adjusted in the job definition from the job configuration page. Timeout on checkout can likewise be adjusted there. Timeout on submodule update is not implemented.
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout is actually occurring on push with the git publisher.
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're seeing a timeout on push, that would usually indicate that the authentication information is not correct. Unless your Jenkins job is adding enormous content to the repository, the push should be a very fast operation.
f841caf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout on push occurs because heroku builds all of the resources as part of the push, so for large web apps it can take up to 15 minutes. Looking at the implementation for the other git 'additional behaviours' it seems like it should be easy to implement a similar timeout override for the push command.