[JENKINS-70158] Fix null pointer exception in GitSCMFileSystem #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
changed the title
When rev was not null and env was null, a null pointer exception was thrown as the code tried to use the null env to expand environment variables in the rev argument. Test duplicates the null pointer exception and this commit resolves the null pointer exception.
MarkEWaite
force-pushed
the
fix-NPE-in-GitSCMFileSystem
branch
from
18463b8
to
67dcdce
Compare
|
Does this amend #1305? |
Yes, it corrects a null pointer exception that was introduced in #1305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-70158 Fix null pointer exception in GitSCMFileSystem
When rev was not null and env was null, a null pointer exception was thrown as the code tried to use the null env to expand environment variables in the rev argument.
First commit duplicates the null pointer exception in a test. Second commit resolves the null pointer exception.
Checklist
Types of changes
Additional comments
@MartinKosicky sorry that we missed the null pointer exception in the code review and in the test automation. Thanks very much for your pull request and for the automated tests that you added. Those tests made it very simple to add one more test for the null pointer exception. That failing test then made it easy to fix the issue in the main code. Thanks again!