Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the browser in a configRoundtrip #1444

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Check the browser in a configRoundtrip #1444

merged 1 commit into from
Apr 27, 2023

Conversation

rsandell
Copy link
Member

@rsandell rsandell commented Apr 27, 2023 •
edited by MarkEWaite
Loading

Check the browser in a configRoundtrip

As discussed in jenkinsci/acceptance-test-harness#1108

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

@rsandell rsandell added the test label Apr 27, 2023
@github-actions github-actions bot removed the test label Apr 27, 2023
MarkEWaite
MarkEWaite approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent. I want to apply that same technique to add more assertions to other configuration data. Thanks very much!

@MarkEWaite MarkEWaite enabled auto-merge (squash) April 27, 2023 12:03
@MarkEWaite MarkEWaite merged commit d7cefd3 into jenkinsci:master Apr 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rsandell @MarkEWaite