Fix remotes wildcard branch spec #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when using "remotes/" in a wildcard branc spec, such as:
remotes/origin/*
The git plugin documentation suggests using the full branch spec
(including remotes/) for branches with slashes. Using "remotes/" in a
wildcard branch should not fail.
This makes matching "remotes/" optional in BranchSpec.
|
plugins » git-plugin #373 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Do Alexander Link's changes that were included in git client plugin 1.10.1 (see the help on "Branches to build") cover this case, or at least provide a path by which this case can be covered (through refs/remotes/wildcard)? If not, does the "regex" syntax (regex is defined by starting the matching string with a leading colon character) meet this need? |
|
After no comment in two months, I'm closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using
remotes/in a wildcard branch spec, such as:Without this patch, new builds fail if using
remotes/and a wildcard in the branch name. If a build has previously run, the previous branch will aways be used instead of the modified branch.This makes matching "remotes/" optional in BranchSpec.