Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-41812] Expose event origin to listeners #471

Merged
merged 3 commits into from Feb 9, 2017

Conversation

stephenc
Copy link
Member

@stephenc stephenc commented Feb 7, 2017

See JENKINS-41812

Downstream of jenkinsci/scm-api-plugin#27

@reviewbybees

pom.xml Outdated
@@ -173,7 +173,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>scm-api</artifactId>
<version>2.0.2</version>
<version>2.0.3-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamp

@stephenc stephenc changed the title [WIP] [FIXED JENKINS-41812] Expose event origin to listeners [FIXED JENKINS-41812] Expose event origin to listeners Feb 7, 2017
@stephenc stephenc merged commit 9d0b4f2 into jenkinsci:2.6.x Feb 9, 2017
@stephenc stephenc deleted the jenkins-41812-2.6.x branch February 9, 2017 15:01

<profiles>
<profile>
<id>java8-doclint-disabled</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do this. Just fix the errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the javadoc warnings were already 100% resolved. Did I miss something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the 2.6.x branch. All failing here. Didn't need this for the master branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. I've generally treated the 2.6.x branch (and the git client plugin 1.21.x branch) as "must be compiled with JDK 7". There were problems in one of those two environments which forced me to stay with JDK 7. I don't remember which, nor do I remember the details of the issues.

Many javadoc fixes were needed on the master branch. I support this exclusion on the 2.6.x branch because it is a branch with limited changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants