New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED JENKINS-41812] Expose event origin to listeners #471
Conversation
pom.xml
Outdated
@@ -173,7 +173,7 @@ | |||
<dependency> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>scm-api</artifactId> | |||
<version>2.0.2</version> | |||
<version>2.0.3-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timestamp
bd14a60
to
7600e7e
Compare
8dbab27
to
64d67e2
Compare
|
||
<profiles> | ||
<profile> | ||
<id>java8-doclint-disabled</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not do this. Just fix the error
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the javadoc warnings were already 100% resolved. Did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the 2.6.x branch. All failing here. Didn't need this for the master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I've generally treated the 2.6.x branch (and the git client plugin 1.21.x branch) as "must be compiled with JDK 7". There were problems in one of those two environments which forced me to stay with JDK 7. I don't remember which, nor do I remember the details of the issues.
Many javadoc fixes were needed on the master branch. I support this exclusion on the 2.6.x branch because it is a branch with limited changes.
See JENKINS-41812
Downstream of jenkinsci/scm-api-plugin#27
@reviewbybees