Fix identity comparison for GitHubSCMSource #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning for new runs, PullRequestSCMRevision instances are compared. While technically one combination of base and pull commit produce the same merge, if we detect a new merge commit we should still treat that as a new revision. For example: Before this change, if a user closes a PR (unmerged) and then reopenes it, a repository scan would not treat the PR as changed. After this change, a closing, reopening, and then scan will result in change being detected with a message like this: Changes detected: PR-3-merge ( 58caa961c3fc5d68268e0d860670041b97cc86b0+edb61773c0185852a5d5c7afc17a924fee730363 (7c907cc0d0eaf15f2b84d030e23f5fd96e1b59d4) -> 58caa961c3fc5d68268e0d860670041b97cc86b0+edb61773c0185852a5d5c7afc17a924fee730363 (e0dd5f238a71951e6a48dc01443fb624a44ff278))
abayer
approved these changes
Apr 16, 2019
|
I followed a rabbit hole to this PR. I'm wondering if it is causing this issue: https://issues.jenkins-ci.org/browse/JENKINS-57583 This PR changes the The underlying base class loosely seems to indicate that the target should not be considered when doing This is then causing the code below to no longer work. I haven't fully vetted all of this so I could be totally off base but would appreciate a second pair of eyes on this. |
|
@awiddersheim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning for new runs, PullRequestSCMRevision instances are compared. While technically one combination of
base and pull commit produce the same merge, if we detect a new merge commit we should still treat that as a new revision.
For example:
Before this change, if a user closes a PR (unmerged) and then reopenes it, a repository scan would not treat the PR as changed.
After this change, a closing, reopening, and then scan will result in change being detected with a message like this (reformatted for clarity):