use http(s)/ssh URL by API's result rathar than fixed pattern. #63
Conversation
|
I can't understand for this Jenkins check.
|
| @@ -327,7 +333,8 @@ public void setBuildForkPRHead(boolean buildForkPRHead) { | |||
|
|
|||
| @Override | |||
| public String getRemote() { | |||
| return getUriResolver().getRepositoryUri(apiUri, repoOwner, repository); | |||
| String credentialsId = getCredentialsId(); | |||
| @@ -134,13 +138,15 @@ | |||
| private @Nonnull Boolean buildForkPRHead = DescriptorImpl.defaultBuildForkPRHead; | |||
|
|
|||
| @DataBoundConstructor | |||
| public GitHubSCMSource(String id, String apiUri, String checkoutCredentialsId, String scanCredentialsId, String repoOwner, String repository) { | |||
| public GitHubSCMSource(String id, String apiUri, String checkoutCredentialsId, String scanCredentialsId, String repoOwner, String repository, String httpGitUrl, String sshGitUrl) { | |||
There was a problem hiding this comment.
Impossible to configure this on a multibranch project without corresponding getters and form fields.
| super(id); | ||
| this.apiUri = Util.fixEmpty(apiUri); | ||
| this.repoOwner = repoOwner; | ||
| this.repository = repository; | ||
| this.scanCredentialsId = Util.fixEmpty(scanCredentialsId); | ||
| this.checkoutCredentialsId = checkoutCredentialsId; | ||
| this.httpGitUrl = Util.fixEmpty(httpGitUrl); | ||
| this.sshGitUrl = Util.fixEmpty(sshGitUrl); |
There was a problem hiding this comment.
Seems like this should be fixed by inspecting the apiUri instead.
|
FindBugs notes: |
|
I think a better plan would be a GitBucket specific implementation. The rate limit complexity in this code base is not likely something that a GitBucket plugin will ever have to deal with, additionally users will not realise that there is a GitBucket plugin for Jenkins unless there is an actual GitBucket plugin for Jenkins. I would recommend using https://github.com/jenkinsci/gitea-plugin as a reference for a nice clean implementation of a GitBucket plugin. In any case, if it is easy to fix the GitHub plugin to use the urls rather than generate them, then that would probably be a change I would like to merge (provided it does not compromise functionality when there are network connectivity issues) If you would like to continue with this change, the codebase should be relatively stable now. A simple ping back to let us know you intend to work on this would be nice. If you do not intend to pick this up in the next 2-3 months, please close the PR. (Note to self, close this PR if no comments after 2017-Aug-3) |
GitBucket is an opensource Git platform with high extensibility & github API compatibility.
It act as GitHub (Enterprise). But some differences are exists.
In GitBucket's side problems are fixed by my PR. gitbucket/gitbucket#1247, gitbucket/gitbucket#1248
But last one problem can't solve by GitBucket side.
PROBLEM
GitBucket provides git repository such as: http://server:port/git/user/repo.git
GitHub Branch Source plugin use fixed pattern URL such as: http://server/user/repo.git
SOLUTION
GitHub and GitBucket API returns http(s)/ssh git repository URL. Clients should use this URL rathar than fixed pattern URL.