-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXES JENKINS-24690] Administrative monitor to show hook registering… #106
Conversation
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
cdb645e
to
4e29eb6
Compare
@@ -0,0 +1 @@ | |||
This job will be triggered if jenkins will receive PUSH GitHub hook from repo defined in scm section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div>
wrapping not required? Don't remember why, but all plugins wrapping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this text will be injected to help-div as html, so no matter - it will be <div><div>text..
or <div>text...
i think. It looks the same for me in UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably div wrapper was introduced in some core version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lanwen should we cleanup other places and plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so. It doesn't change anything
[FIXES JENKINS-24690] Administrative monitor to show hook registering…
… problems
JENKINS-24690
Warning in the job config
Administrative monitor message
Link to administrative monitor in global management
Management of administrative monitor