Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES JENKINS-24690] Administrative monitor to show hook registering… #106

Merged
merged 1 commit into from
Jan 26, 2016

Conversation

lanwen
Copy link
Member

@lanwen lanwen commented Jan 17, 2016

… problems
JENKINS-24690

Warning in the job config

2016-01-24 21-26-26 job-test config jenkins

Administrative monitor message

2016-01-24 21-27-34 jenkins jenkins

Link to administrative monitor in global management

2016-01-24 21-28-00 jenkins jenkins

Management of administrative monitor

2016-01-24 21-28-37 github hooks problems jenkins

Review on Reviewable

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@lanwen lanwen force-pushed the hook_monitor branch 2 times, most recently from cdb645e to 4e29eb6 Compare January 24, 2016 18:18
@lanwen lanwen changed the title [WIP][FIXES JENKINS-24690] Administrative monitor to show hook registering… [FIXES JENKINS-24690] Administrative monitor to show hook registering… Jan 24, 2016
@@ -0,0 +1 @@
This job will be triggered if jenkins will receive PUSH GitHub hook from repo defined in scm section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<div> wrapping not required? Don't remember why, but all plugins wrapping it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this text will be injected to help-div as html, so no matter - it will be <div><div>text.. or <div>text... i think. It looks the same for me in UI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably div wrapper was introduced in some core version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanwen should we cleanup other places and plugins?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so. It doesn't change anything

lanwen added a commit that referenced this pull request Jan 26, 2016
[FIXES JENKINS-24690] Administrative monitor to show hook registering…
@lanwen lanwen merged commit c0b718e into jenkinsci:master Jan 26, 2016
@lanwen lanwen deleted the hook_monitor branch January 26, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants