Fixed incorrect proxy configuration of GitHubLoginFunction #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't be better made matching in core? |
|
I thought of changing this in the core aswell, but it explicitly says |
|
Then 👍 , let's wait for @lanwen review |
|
Thanks for the fix! |
lanwen
added a commit
that referenced
this pull request
Jan 28, 2016
Fixed incorrect proxy configuration of GitHubLoginFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jenkins ProxyConfiguration class expects only the hostname (e.g.
git.example.comvshttps://git.example.com/api/) as a method parameter tocreateProxy, but the existing code gives it the whole URL.As a result of this, the validation of no proxy hosts is not correct. In most cases this is not a problem, but it is for some enterprise GitHub instances.
The handling of the possible MalformedURLException might not be the most suitable, it may needs to be replaced.