prevent JS in link to github #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +34,7 @@ public String getIconFileName() { | |||
|
|
|||
| @Override | |||
| public String getUrlName() { | |||
| return projectProperty.getProjectUrl().baseUrl(); | |||
| return XSSApi.asValidHref(projectProperty.getProjectUrl().baseUrl()); | |||
There was a problem hiding this comment.
Functions.*escape* hudson.Util#escape
There was a problem hiding this comment.
nope. They can't escape js
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| */ | ||
| public static String asValidHref(String urlString) { | ||
| try { | ||
| return new URL(urlString).toExternalForm(); |
There was a problem hiding this comment.
What happens to relative links? Protocol-relative URLs? Tests don't cover those.
There was a problem hiding this comment.
Expecting github url is scheme + fqdn + project path all other urls will be filtered (added tests for such cases)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is