Extended setter for status #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| * @return true if exception handled successfully | ||
| * @throws Exception you can rethrow exception of any type | ||
| */ | ||
| boolean handle(Exception e, @Nonnull Run<?, ?> run, @Nonnull TaskListener listener) throws Exception; |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one. 
| when(env.expand(Matchers.anyString())).thenReturn(EXPANDED); | ||
|
|
||
| String context = new ManuallyEnteredShaSource("").get(run, listener); | ||
| assertThat(context, equalTo(EXPANDED)); |
There was a problem hiding this comment.
Add a message to this assertion.
Deprecate them. Make PENDING setter not to fail build on any errors, as of most of the people don't want to fail the entire build because of we can't set status
|
SonarQube analysis reported 4 issues:
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also will be:
extended pipeline dsl(require core dep updating, will be in next pr)linked with:
This change is