[FIXED JENKINS-38347] Use Initializer levels. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrator: Don't throw NPE because Descriptor wasn't ready. - aliases: user annotation initializer.
|
@lanwen @atanasenko for review |
KostyaSha
commented
Sep 19, 2016
| @@ -21,21 +24,17 @@ | |||
| * Launched before plugin starts | |||
| * Adds alias for {@link GitHubPlugin} to simplify resulting xml | |||
| */ | |||
| public static void init() { | |||
| @Initializer(before = PLUGINS_STARTED) | |||
There was a problem hiding this comment.
level needs to be checked
There was a problem hiding this comment.
Added workaround to ensure order
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
lanwen
reviewed
Sep 19, 2016
| @@ -21,25 +24,31 @@ | |||
| * Launched before plugin starts | |||
| * Adds alias for {@link GitHubPlugin} to simplify resulting xml | |||
| */ | |||
| public static void init() { | |||
| // @Initializer(before = PLUGINS_STARTED) | |||
There was a problem hiding this comment.
Shows real level of this step, can move to javadoc.
There was a problem hiding this comment.
I kept it just to not start thinking in future what was the right level.
There was a problem hiding this comment.
move it to javadoc plz - now it looks like a forgotten block of code
|
+1 |
|
thanks! |
|
Thanks guys! |
pdunnavant
pushed a commit
to 4INGS/github-plugin
that referenced
this pull request
Oct 29, 2016
* [FIXED JENKINS-38347] Use Initializer levels. - migrator: Don't throw NPE because Descriptor wasn't ready. - aliases: user annotation initializer. * Ensure execution order. Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com> * Move to javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-38347
This change is