Add Webhook register problem to Troubleshooting #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins is adding categories to MagagementLink to group item. This change adds the webhook problem item to the "Troubleshooting" category. see jenkinsci/jenkins#4546 see jenkinsci/script-security-plugin#302
KostyaSha
reviewed
Jul 29, 2020
| @@ -253,5 +253,11 @@ public String getDescription() { | |||
| public String getDisplayName() { | |||
| return Messages.hooks_problem_administrative_monitor_displayname(); | |||
| } | |||
|
|
|||
| // TODO: Override `getCategory` instead using `Category.TROUBLESHOOTING` when minimum core version is 2.226+, | |||
There was a problem hiding this comment.
Yes, that is the point. This makes this work and build with earlier versions like 2.164.3 but also return a category when run on later versions that support categories.
|
@KostyaSha Can we go ahead and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins is adding categories to MagagementLink to group item.
This change adds the webhook problem item to the "Troubleshooting" category.
see jenkinsci/jenkins#4546
see jenkinsci/script-security-plugin#302