use GlobalConfiguration extension point to store all global config #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
lanwen
force-pushed
the
global_conf
branch
3 times, most recently
from
72fd2fa
to
3ca8885
Compare
KostyaSha
changed the title
| @@ -0,0 +1,2 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <com.cloudbees.jenkins.GitHubPushTrigger_-DescriptorImpl plugin="github@1.13.0-SNAPSHOT"/> | |||
There was a problem hiding this comment.
Should not be a SNAPSHOT. 1.12?
There was a problem hiding this comment.
it can be any. It's just current build version. (its not affect tests)
There was a problem hiding this comment.
Please use the released version. Otherwise it may be hard to triangulate migration causes, etc.
this simplifies resulting config classes and xml-files
|
👍 |
| public void setConfigs(List<GitHubServerConfig> configs) { | ||
| this.configs = configs; | ||
| } | ||
|
|
||
| public List<GitHubServerConfig> getConfigs() { | ||
| return configs; |
There was a problem hiding this comment.
FindBugs will complain about the internal implementation exposure
There was a problem hiding this comment.
will think about it on find bugs stage
|
👍 |
KostyaSha
added a commit
that referenced
this pull request
Aug 17, 2015
use GlobalConfiguration extension point to store all global config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this simplifies resulting config classes and xml-files
new config looks like
(no migration from #65)
inspired by jenkinsci/envinject-plugin#57