checkstyle with contributing guides #69
Conversation
| ## Indentation | ||
|
|
||
| 1. **Use spaces.** Tabs are banned. | ||
| 2. **Java blocks are 4 spaces.** JavaScript blocks as for Java. **XML nesting is 4 spaces** |
There was a problem hiding this comment.
xml with 4 spaces become very wide
|
CONTRIBUTING.md first of all should contain links to jenkins documentation and jira |
|
Test failed, master was ok |
| + Change `Do not wrap` to `Wrap if long` | ||
| + Change `Do not force` to `Always` | ||
| - Javadoc | ||
| + Disable generating `<p/>` on empty lines |
There was a problem hiding this comment.
it's ugly. We not going to generate javadoc site, so it should be readable as is. <p/> is not for reading it as is
lanwen
force-pushed
the
checkstyle
branch
4 times, most recently
from
1e91c60
to
a10bf6e
Compare
no any functional change, only code style and maven-checkstyle-plugin in pom
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
There was a problem hiding this comment.
put all namespaces on new line?
There was a problem hiding this comment.
its autoformatting side effect. Think can be ignored
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
👎 it causes too much merge issues for the people. The change should not enforce checkstyle for the old code (at least now) |
|
@oleg-nenashev other PRs (except workflow) are not actual and workflow can be easily updated ourself. Coding style is really required for comfort development and bugs reduction, so it need to be merged. Also no back-porting in this plugin expected (for hotfix i preserving minor version now). |
|
@oleg-nenashev only workflow PR is active. I'll rebase it myself. I'll help with FB |
| GitHubCommitNotifier_SettingCommitStatus(repository.getHtmlUrl() + "/commit/" + sha1) | ||
| ); | ||
| repository.createCommitStatus( | ||
| sha1, state, build.getAbsoluteUrl(), msg, build.getProject().getFullName()); |
There was a problem hiding this comment.
on previous line of code had new line, here not...
|
ok with 120, though it looks ugly for loggers and some variable creations :( |
checkstyle with contributing guides
no any functional change, only code style and maven-checkstyle-plugin in pom