fix checking creds on github enterprise #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also additional fixes mentioned in jenkinsci#88
| @@ -257,6 +257,7 @@ public FormValidation doVerifyCredentials( | |||
| @QueryParameter String apiUrl, @QueryParameter String credentialsId) throws IOException { | |||
|
|
|||
| GitHubServerConfig config = new GitHubServerConfig(credentialsId); | |||
| config.setCustomApiUrl(isUrlCustom(apiUrl)); | |||
There was a problem hiding this comment.
that's why i prefered to have direct url without any boolean checkboxes
There was a problem hiding this comment.
when this component will be in jenkins, it will be much easier to avoid such logic here
|
LGTM |
|
👍 |
KostyaSha
added a commit
that referenced
this pull request
Sep 27, 2015
fix checking creds on github enterprise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also additional fixes mentioned in #88