Separate cache for each server config #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
changed the title
| @@ -180,8 +180,8 @@ | |||
| <plugin> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <configuration> | |||
| <source>1.6</source> | |||
| <target>1.6</target> | |||
| <source>1.7</source> | |||
There was a problem hiding this comment.
TODO don't forget mark in changelog 1.7 requirement
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
lanwen
force-pushed
the
separate_cache
branch
3 times, most recently
from
9266983
to
f153264
Compare
This change requires java 1.7 to use java.nio as more effective way to operate files. This implementation creates directory with name as hash of each pair <api url+creds>. Redundant dirs removed on each save of global config.
lanwen
changed the title
| private OkHttpConnector connector(String apiUrl) { | ||
| OkHttpClient client = new OkHttpClient().setProxy(getProxy(apiUrl)); | ||
| private OkHttpConnector connector(GitHubServerConfig config) { | ||
| OkHttpClient client = new OkHttpClient().setProxy(getProxy(defaultIfBlank(config.getApiUrl(), GITHUB_URL))); |
There was a problem hiding this comment.
wouldn't this mask issue when something is broken and url get blank?
i.e. user entered url, jelly magic failed, connection created with public connection and user didn't get thrown error
There was a problem hiding this comment.
Insurance just in case. This should never happen until somebody will call directly classes from internals
|
👍 LGTM besides using defaults when real url is expected. |
KostyaSha
added a commit
that referenced
this pull request
Oct 6, 2015
Separate cache for each server config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires java 1.7 to use java.nio as more effective way to operate files.
This implementation creates directory with name as hash of each pair
<api url+creds>.Redundant dirs removed on each save of global config.