Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File formatting improvements #74

Merged
merged 4 commits into from Jul 5, 2019
Merged

File formatting improvements #74

merged 4 commits into from Jul 5, 2019

Conversation

@darxriggs
Copy link
Contributor

darxriggs commented Jul 4, 2019

No description provided.

@wolfs

This comment has been minimized.

Copy link
Member

wolfs commented Jul 5, 2019

@darxriggs Thank you for the changes! What tool did you use to find the whitespace problems? Can I add an automated check so this doesn't creep in any more?

@wolfs wolfs merged commit 127bdb2 into jenkinsci:master Jul 5, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@darxriggs

This comment has been minimized.

Copy link
Contributor Author

darxriggs commented Jul 5, 2019

I am currently investigating https://pre-commit.com.
So yes, some checks can be automated.

.pre-commit-config.yaml you could start with:

# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
  rev: v2.2.3
  hooks:
    - id: check-added-large-files
    - id: check-merge-conflict
    - id: check-symlinks
    - id: check-xml
    - id: check-yaml
    - id: end-of-file-fixer
    - id: mixed-line-ending
    - id: trailing-whitespace
- repo: https://github.com/jumanjihouse/pre-commit-hooks
  rev: 1.11.0
  hooks:
    - id: git-check
    - id: require-ascii
      exclude: '[.]properties$'
- repo: https://github.com/Lucas-C/pre-commit-hooks
  rev: v1.1.6
  hooks:
    - id: forbid-crlf
    - id: forbid-tabs
@darxriggs darxriggs deleted the darxriggs:improvements branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.