Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all XML based config #10

Closed
timja opened this issue Aug 26, 2020 · 2 comments · Fixed by #153
Closed

Remove all XML based config #10

timja opened this issue Aug 26, 2020 · 2 comments · Fixed by #153
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@timja
Copy link
Member

timja commented Aug 26, 2020

Use JCasC config instead

Currently the chart has two configuration options:

via XML configuration files, which basically renders XML documents
via Configuration as Code plugins
The second one is preferred as it allows updating the configuration. With XML that's impossible as users could have changed settings via the Jenkins UI.

As the chart support JCasC configuration I suggest to get rid of all XML configuration options. This hopefully also makes it easier for users of the chart as they don't have to worry about if a configuration is done via XML or JCasC and be surprised if their setting is not applied.

@torstenwalter
Copy link
Member

With #34 I created a draft which removes all XML configuration options.
Would appreciate any help in reviewing it. I tried to remove things from inner blocks to outer ones to not to forget removing values from values.yaml which are no longer used.

These are quite some changes after all...

@torstenwalter torstenwalter added this to the v3.0.0 release milestone Sep 28, 2020
@torstenwalter torstenwalter added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 5, 2020
@torstenwalter torstenwalter mentioned this issue Nov 24, 2020
4 tasks
@torstenwalter
Copy link
Member

Closed with #34 and #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants