Remove xml configuration options #34
Conversation
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
I kept the values as we whould implement this via JCasC Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
force-pushed
the
remove-xml-configuration-options
branch
from
b92bed4
to
d88d1e0
Compare
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
force-pushed
the
remove-xml-configuration-options
branch
2 times, most recently
from
9931c77
to
d5dc231
Compare
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
force-pushed
the
remove-xml-configuration-options
branch
from
d5dc231
to
0fbb74e
Compare
|
@wmcdona89 Would be great if you could have a look at it. Appreciate your feedback. |
| @@ -34,25 +32,17 @@ The following tables list the configurable parameters of the Jenkins chart and t | |||
| | Parameter | Description | Default | | |||
| | --------------------------------- | ------------------------------------ | ----------------------------------------- | | |||
| | `master.initScripts` | List of Jenkins init scripts | `[]` | | |||
| | `master.overwriteConfig` | Replace init scripts and config w/ ConfigMap on boot | `false` | | |||
| | `master.credentialsXmlSecret` | Kubernetes secret that contains a 'credentials.xml' file | Not set | | |||
| | `master.secretsFilesSecret` | Kubernetes secret that contains 'secrets' files | Not set | | |||
There was a problem hiding this comment.
I think we need to keep this. it's used, for example, to set hudson.util.Secret and master.key from a Kubernetes Secret so credentials are portable between instances. this isn't supported by JCasC yet...see here.
There was a problem hiding this comment.
I would rather point people to https://jenkinsci.github.io/kubernetes-credentials-provider-plugin/.
There was a problem hiding this comment.
kubernetes-credentials-provider-plugin is great for loading top-level credentials from k8s secrets...and it appears it will support folder-level credentials once this PR is merged...but I don't expect it will ever support loading the encryption keys
There was a problem hiding this comment.
Why do you want to load the encryption key?
There was a problem hiding this comment.
blue/green deployments require encrypted folder-level credentials to be portable
I'm realizing I won't need to load the encryption key once kubernetes-credentials-provider-plugin supports folder-level credentials...but it's needed in the meantime to manage encrypted folder-level credentials via the Job DSL plugin
| | Parameter | Description | Default | | ||
| | --------------------------------- | ------------------------------------ | ----------------------------------------- | | ||
| | `master.customConfigMap` | Deprecated: Use a custom ConfigMap | `false` | | ||
| | `master.additionalConfig` | Deprecated: Add additional config files | `{}` | |
There was a problem hiding this comment.
any idea why master.additionalConfig was deprecated? it's definitely useful for getting one-off configuration onto the server which can be processed by an init script. I actually use it to work around a Job DSL plugin issue regarding string credentials. I'm just discovering this issue has a workaround so perhaps I'll no longer need master.additionalConfig...but I wouldn't be surprised if others are using it for similar workarounds.
There was a problem hiding this comment.
Could you explain how you are using it? Could you mount a volume instead?
If we can then it would be great to get rid of copying files and having conditionals to either do it only once or to overwrite existing files.
There was a problem hiding this comment.
I like having the configuration in my values file vs managing it out of band. since my configuration is related to folder-level credentials, I'd now rather use the Job DSL plugin workaround or kubernetes-credentials-provider-plugin once it adds support for folder-level credentials.
since this field has been deprecated since v0.29.0 then it's definitely due to be removed...and hopefully any other use cases for it now have better options
There was a problem hiding this comment.
Good pointer. to the PR of the credentials-provider-plugin.
|
Are there any other configuration options which should be removed? |
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
|
closing this as it's part of the jenkins-3-0-0 branch |
Part-of: #10